CloudyScripts 2.14.60 → 2.14.62

data/Rakefile

@@ -13,7 +13,7 @@ require 'rake/testtask'
 spec = Gem::Specification.new do |s|
   s.name = 'CloudyScripts'
   #s.version = '2.14.54' #<number cloud-stacks supported>.<number cloud-scripts>.<counting releases>
-  s.version = '2.14.60' #<number cloud-stacks supported>.<number cloud-scripts>.<counting releases>
+  s.version = '2.14.62' #<number cloud-stacks supported>.<number cloud-scripts>.<counting releases>
   s.has_rdoc = true
   s.extra_rdoc_files = ['README.rdoc', 'LICENSE']
   s.summary = 'Scripts to facilitate programming for infrastructure clouds.'

data/lib/help/helper.rb

@@ -12,3 +12,26 @@ def check_string_alnum(str)
   end
   return true
 end
+
+# API Reference (API Version 2012-07-20): 
+# http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-RegisterImage.html
+# Check name for AWS AMI registration
+# Constraints: 3-128 alphanumeric characters, parenthesis (()), commas (,), slashes (/), dashes (-), or underscores(_)
+def check_aws_name(str)
+  if str.match(/^[0-9a-z\-\_\(\)\/\,]{1,128}$/i)
+    return true
+  else
+    return false
+  end
+  return true 
+end
+
+# Check description for AWS AMI registration
+# Constraints: Up to 255 characters
+def check_aws_desc(str)
+  if str.size <= 255
+    return true
+  else
+    return false
+  end
+end

data/lib/help/state_transition_helper.rb

@@ -78,8 +78,13 @@ module StateTransitionHelper
     end
     os = remote_handler().retrieve_os()
     sudo = remote_handler().use_sudo ? " [sudo]" : ""
+    if os =~ /^Please login as .+$/i
+      post_message("not connected to #{dns_name}#{sudo} due to an invalid user.")
+      @logger.error "not connected to #{dns_name}#{sudo} due to an invalid user."
+      raise Exception.new("invalid user: #{os}")
+    end
     post_message("connected to #{dns_name}#{sudo}. OS installed is #{os}")
-    @logger.info "connected to #{dns_name}#{sudo}"
+    @logger.info "connected to #{dns_name}#{sudo} OS installed is #{os}"
     return os
   end
 
@@ -558,6 +563,39 @@ module StateTransitionHelper
     return image_id
   end
 
+  def create_security_group_with_rules(name, desc, rules)
+    post_message("going to create '#{name}' Security Group...")
+    @logger.debug "create Security Group (name: #{name}, desc: #{desc})"
+    begin
+      res = ec2_handler().describe_security_groups(:group_name => name)
+      if res['securityGroupInfo']['item'].size > 0
+        @logger.warn "'#{name}' Security Group found. Another Security Group already exists with the same name. Deleting it first."
+        res = ec2_handler().delete_security_group(:group_name => name) 
+      end
+    rescue AWS::InvalidGroupNotFound => e
+      @logger.debug "'#{name}' Security Group not found."
+    end
+    res = ec2_handler().create_security_group(:group_name => name, :group_description => desc)
+    rules.each(){ |rule|
+      ec2_handler().authorize_security_group_ingress(:group_name => name,
+        :ip_protocol => rule[:ip_protocol], :from_port => rule[:from_port], :to_port => rule[:to_port], :cidr_ip => rule[:cidr_ip])
+    }
+    return true
+  end
+
+  def delete_security_group(name)
+    post_message("going to delete '#{name}' Security Group...")
+    @logger.debug "delete Security Group (name: #{name})"
+    res = ec2_handler().describe_security_groups(:group_name => name)
+    if res['securityGroupInfo']['item'].size > 0
+      @logger.debug "'#{name}' Security Group found."
+      res = ec2_handler().delete_security_group(:group_name => name) 
+    else
+      @logger.warn "'#{name}' Security Group not found."
+    end
+    return true
+  end
+
   # Create a file-system on a given machine (assumes to be connected already).
   # Input Parameters:
   # * dns_name => IP used
@@ -699,7 +737,7 @@ module StateTransitionHelper
       @logger.error "#{msg}"
       raise Exception.new("#{mount_point} still mounted")
     else
-      msg = "#{mount_point} successfully mounted" 
+      msg = "#{mount_point} successfully unmounted" 
       @logger.info "#{msg}"
     end
     post_message("#{msg}")
@@ -1204,8 +1242,11 @@ module StateTransitionHelper
                             'aki-b4aa75dd' => 'pv-grub-hd00_1.03-x86_64',
 
                             #RHEL kernel Amazon Kernel ID
-                            'aki-36ed075f' => 'aki-rhel-i386',
-                            'aki-08ed0761' => 'aki-rhel-x86_64'	
+                            'aki-36ed075f' => 'aki-rhel-i386',		# RH-pv-grub-hd0-V1.01-i386
+                            'aki-08ed0761' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                            #Ubuntu kernel Amazon Kernel ID
+                            'aki-5f15f636' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            }, 
             'us-west-1' => {'aki-9da0f1d8' => 'pv-grub-hd00-V1.01-i386',
                             'aki-9fa0f1da' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1221,8 +1262,11 @@ module StateTransitionHelper
                             'aki-eb7e26ae' => 'pv-grub-hd00_1.03-x86_64',
 
                             #RHEL kernel Amazon Kernel ID:
-                            'aki-772c7f32' => 'aki-rhel-i386',	# RH-pv-grub-hd0-V1.01-i386
-                            'aki-712c7f34' => 'aki-rhel-x86_64'	# RH-pv-grub-hd0-V1.01-x86_64
+                            'aki-772c7f32' => 'aki-rhel-i386',		# RH-pv-grub-hd0-V1.01-i386
+                            'aki-712c7f34' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                            #Ubuntu kernel Amazon Kernel ID
+                            'aki-773c6d32' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            },
             'us-west-2' => {'aki-dee26fee' => 'pv-grub-hd00-V1.01-i386',
                             'aki-90e26fa0' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1238,8 +1282,11 @@ module StateTransitionHelper
                             'aki-f837bac8' => 'pv-grub-hd00_1.03-x86_64',
 
                             #RHEL kernel Amazon Kernel ID
-                            'aki-2efa771e' => 'aki-rhel-i386',
-                            'aki-10fa7720' => 'aki-rhel-x86_64'
+                            'aki-2efa771e' => 'aki-rhel-i386',		# RH-pv-grub-hd0-V1.01-i386
+                            'aki-10fa7720' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                            #Ubuntu kernel Amazon Kernel ID
+                            '' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            },
             'eu-west-1' => {'aki-47eec433' => 'pv-grub-hd00-V1.01-i386',
                             'aki-41eec435' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1255,8 +1302,11 @@ module StateTransitionHelper
                             'aki-8b655dff' => 'pv-grub-hd00_1.03-x86_64',
 
                             #RHEL kernel Amazon Kernel ID
-                            'aki-af0a3ddb' => 'aki-rhel-i386',
-                            'aki-a90a3ddd' => 'aki-rhel-x86_64'	
+                            'aki-af0a3ddb' => 'aki-rhel-i386',		# RH-pv-grub-hd0-V1.01-i386
+                            'aki-a90a3ddd' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                            #Ubuntu kernel Amazon Kernel ID
+                            'aki-b02a01c4' => 'aki-ubuntu-karmic-v2.6.31-302.i386'	
                            },
             'ap-southeast-1' => {'aki-6fd5aa3d' => 'pv-grub-hd00-V1.01-i386',
                                  'aki-6dd5aa3f' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1272,8 +1322,11 @@ module StateTransitionHelper
                                  'aki-fa1354a8' => 'pv-grub-hd00_1.03-x86_64',
 
                                  #RHEL kernel Amazon Kernel ID
-                                 'aki-9c235ace' => 'aki-rhel-i386',
-                                 'aki-82235ad0' => 'aki-rhel-x86_64'	
+                                 'aki-9c235ace' => 'aki-rhel-i386',	# RH-pv-grub-hd0-V1.01-i386
+                                 'aki-82235ad0' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                                 #Ubuntu kernel Amazon Kernel ID
+                                 'aki-87f38cd5' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            },
             'ap-northeast-1' => {'aki-d209a2d3' => 'pv-grub-hd00-V1.01-i386',
                                  'aki-d409a2d5' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1289,8 +1342,11 @@ module StateTransitionHelper
                                  'aki-40992841' => 'pv-grub-hd00_1.03-x86_64',
 
                                  #RHEL kernel Amazon Kernel ID
-                                 'aki-66c06a67' => 'aki-rhel-i386',
-                                 'aki-68c06a69' => 'aki-rhel-x86_64'
+                                 'aki-66c06a67' => 'aki-rhel-i386',	# RH-pv-grub-hd0-V1.01-i386
+                                 'aki-68c06a69' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                                 #Ubuntu kernel Amazon Kernel ID
+                                 'aki-540fa455' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            },
             'sa-east-1' => {'aki-803ce39d' => 'pv-grub-hd00-V1.01-i386',
                             'aki-d03ce3cd' => 'pv-grub-hd00-V1.01-x86_64',
@@ -1306,8 +1362,11 @@ module StateTransitionHelper
                             'aki-c88f51d5' => 'pv-grub-hd00_1.03-x86_64',
 
                             #RHEL kernel Amazon Kernel ID
-                            'aki-1a38e707' => 'aki-rhel-i386',
-                            'aki-1438e709' => 'aki-rhel-x86_64'
+                            'aki-1a38e707' => 'aki-rhel-i386',		# RH-pv-grub-hd0-V1.01-i386
+                            'aki-1438e709' => 'aki-rhel-x86_64',	# RH-pv-grub-hd0-V1.01-x86_64
+
+                            #Ubuntu kernel Amazon Kernel ID
+                            '' => 'aki-ubuntu-karmic-v2.6.31-302.i386'
                            }
           }
     target_aki = ''

data/lib/scripts/ec2/ami2_ebs_conversion.rb

@@ -43,7 +43,6 @@ class Ami2EbsConversion < Ec2Script
     end
     if @input_params[:name] == nil
       @input_params[:name] = "Boot EBS (for AMI #{@input_params[:ami_id]}) at #{Time.now.strftime('%d/%m/%Y %H.%M.%S')}"
-    else
     end
     if @input_params[:description] == nil
       @input_params[:description] = @input_params[:name]
@@ -111,6 +110,7 @@ class Ami2EbsConversion < Ec2Script
   # Storage attached. Create a file-system and mount it
   class StorageAttached < Ami2EbsConversionState
     def enter
+      #TODO: Fix connect to use username even if ssh_keyfile is specified or do not specify it
       @context[:result][:os] =
         connect(@context[:dns_name], @context[:ssh_username],
         @context[:ssh_keyfile], @context[:ssh_keydata],

data/lib/scripts/ec2/copy_ami.rb

@@ -48,12 +48,24 @@ class CopyAmi < Ec2Script
       raise Exception.new("must be an EBS type image")
     end
     local_ec2_helper = ec2_helper
-    if !local_ec2_helper.check_open_port('default', 22)
-      raise Exception.new("Port 22 must be opened for security group 'default' to connect via SSH in source-region")
+    if @input_params[:source_security_group] == nil
+      @input_params[:source_security_group] = "default"
+    end
+    if !local_ec2_helper.check_open_port(@input_params[:source_security_group], 22)
+      post_message("'#{@input_params[:source_security_group]}' Security Group not opened port 22 for connect via SSH in source region")
+      @input_params[:source_security_group] = nil
+    else
+      post_message("'#{@input_params[:source_security_group]}' Security Group opened port 22 for connect via SSH in source region")
     end
     remote_ec2_helper = Ec2Helper.new(@input_params[:target_ec2_handler])
-    if !remote_ec2_helper.check_open_port('default', 22)
-      raise Exception.new("Port 22 must be opened for security group 'default' to connect via SSH in target-region")
+    if @input_params[:target_security_group] == nil
+      @input_params[:target_security_group] = "default"
+    end
+    if !remote_ec2_helper.check_open_port(@input_params[:target_security_group], 22)
+      post_message("'#{@input_params[:target_security_group]}' Security Group not opened port 22 for connect via SSH in target region")
+      @input_params[:target_security_group] = nil
+    else
+      post_message("'#{@input_params[:target_security_group]}' Security Group opened port 22 for connect via SSH in target region")
     end
     if @input_params[:root_device_name] == nil
       @input_params[:root_device_name] = "/dev/sda1"
@@ -67,9 +79,12 @@ class CopyAmi < Ec2Script
     if @input_params[:target_ssh_username] == nil
       @input_params[:target_ssh_username] = "root"
     end
-    if @input_params[:description] == nil || !check_string_alnum(@input_params[:description])
+    if @input_params[:description] == nil || !check_aws_desc(@input_params[:description])
       @input_params[:description] = "Created by CloudyScripts - #{self.class.name}"
     end
+    if @input_params[:name] == nil || !check_aws_name(@input_params[:name])
+      @input_params[:name] = "Created_by_CloudyScripts/#{self.class.name}_from_#{@input_params[:ami_id]}"
+    end
   end
 
   # Load the initial state for the script.
@@ -99,12 +114,21 @@ class CopyAmi < Ec2Script
   # Initial state: start up AMI in source region
   class InitialState < CopyAmiState
     def enter()
+      local_region()
+      #XXX: create a CloudyScripts Security Group with TCP port 22 publicly opened
+      if @context[:source_security_group] == nil
+        @context[:source_security_group] = Ec2Script::CS_SEC_GRP_NAME
+        create_security_group_with_rules(@context[:source_security_group], Ec2Script::CS_SEC_GRP_DESC, 
+          [{:ip_protocol => "tcp", :from_port => 22, :to_port => 22, :cidr_ip => "0.0.0.0/0"}])
+        post_message("'#{@context[:source_security_group]}' Security Group created with TCP port 22 publicly opened.")
+      end
+
       @context[:source_instance_id], @context[:source_dns_name], @context[:source_availability_zone], 
         @context[:kernel_id], @context[:ramdisk_id], @context[:architecture], @context[:root_device_name] =
-        launch_instance(@context[:ami_id], @context[:source_key_name], "default")
+        launch_instance(@context[:ami_id], @context[:source_key_name], @context[:source_security_group])
       ec2_helper = Ec2Helper.new(@context[:ec2_api_handler])
-      puts "get_attached returns: #{ec2_helper.get_attached_volumes(@context[:source_instance_id]).inspect}"
-      @context[:ebs_volume_id] = ec2_helper.get_attached_volumes(@context[:source_instance_id])[0]['volumeId']#TODO: what when more root devices?
+      @context[:ebs_volume_id] = ec2_helper.get_attached_volumes(@context[:source_instance_id])[0]['volumeId']	#TODO: what when more root devices?
+
       SourceInstanceLaunchedState.new(@context)
     end
   end
@@ -114,6 +138,7 @@ class CopyAmi < Ec2Script
     def enter()
       @context[:snapshot_id] = create_snapshot(@context[:ebs_volume_id], 
         "Created by CloudyScripts - #{self.get_superclass_name()} from #{@context[:ebs_volume_id]}")
+
       AmiSnapshotCreatedState.new(@context)
     end
   end
@@ -167,6 +192,7 @@ class CopyAmi < Ec2Script
       #@context[:fs_type] = get_root_partition_fs_type()
       @context[:fs_type], @context[:label] = get_root_partition_fs_type_and_label()
       disconnect()
+
       SourceVolumeReadyState.new(@context)
     end
   end
@@ -175,11 +201,19 @@ class CopyAmi < Ec2Script
   class SourceVolumeReadyState < CopyAmiState
     def enter()
       remote_region()
-      result = launch_instance(@context[:target_ami_id], @context[:target_key_name], 
-        "default")
+      #XXX: create a CloudyScripts Security Group with TCP port 22 publicly opened
+      if @context[:target_security_group] == nil
+        @context[:target_security_group] = Ec2Script::CS_SEC_GRP_NAME
+        create_security_group_with_rules(@context[:target_security_group], Ec2Script::CS_SEC_GRP_DESC, 
+          [{:ip_protocol => "tcp", :from_port => 22, :to_port => 22, :cidr_ip => "0.0.0.0/0"}])
+        post_message("'#{@context[:target_security_group]}' Security Group created with TCP port 22 publicly opened.")
+      end
+
+      result = launch_instance(@context[:target_ami_id], @context[:target_key_name], @context[:target_security_group])
       @context[:target_instance_id] = result.first
       @context[:target_dns_name] = result[1]
       @context[:target_availability_zone] = result[2]
+
       TargetInstanceLaunchedState.new(@context)
     end
   end
@@ -211,6 +245,7 @@ class CopyAmi < Ec2Script
       create_labeled_fs(@context[:target_dns_name], device, @context[:fs_type], @context[:label])
       mount_fs(mount_point, device)
       disconnect()
+
       TargetVolumeReadyState.new(@context)
     end
   end
@@ -229,8 +264,8 @@ class CopyAmi < Ec2Script
       #  @context[:target_ssh_keyfile], "#{key_path}#{@context[:target_key_name]}.pem")
       upload_file(@context[:source_dns_name], @context[:source_ssh_username], @context[:source_ssh_keydata],
         @context[:target_ssh_keyfile], "#{key_path}#{@context[:target_key_name].gsub(/\s+/, '_')}.pem")
-
       post_message("credentials are in place to connect source and target.")
+
       KeyInPlaceState.new(@context)
     end
   end
@@ -256,6 +291,7 @@ class CopyAmi < Ec2Script
       enable_ssh_tty(@context[:target_dns_name])
       unmount_fs(dest_dir)
       disconnect()
+
       DataCopiedState.new(@context)
     end
   end
@@ -267,6 +303,7 @@ class CopyAmi < Ec2Script
       remote_region()
       @context[:new_snapshot_id] = create_snapshot(@context[:target_volume_id], 
         "Created by CloudyScripts - #{self.get_superclass_name()} from #{@context[:target_volume_id]}")
+
       TargetSnapshotCreatedState.new(@context)
     end
   end
@@ -285,29 +322,73 @@ class CopyAmi < Ec2Script
       end
       @context[:result][:image_id] = register_snapshot(@context[:new_snapshot_id], @context[:name],
         device, @context[:description], aki, nil, @context[:architecture])
+
       AmiRegisteredState.new(@context)
     end
   end
 
   # AMI is registered. Now only cleanup is missing, i.e. shut down instances and
   # remote the volumes that were created. Start with cleaning the ressources
-  # in the local region.
+  # in the both regions.
   class AmiRegisteredState < CopyAmiState
     def enter()
+      error = []
       local_region()
-      shut_down_instance(@context[:source_instance_id])
-      delete_volume(@context[:source_volume_id])
-      delete_snapshot(@context[:snapshot_id])
-      SourceCleanedUpState.new(@context)
-    end
-  end
-
-  # Cleanup the resources in the target region.
-  class SourceCleanedUpState < CopyAmiState
-    def enter()
+      begin
+        shut_down_instance(@context[:source_instance_id])
+      rescue Exception => e
+        error << e
+        post_message("Unable to shutdown instance '#{@context[:source_instance_id]}' in source region: #{e.to_s}")
+      end
+      begin
+        delete_volume(@context[:source_volume_id])
+      rescue Exception => e
+        error << e
+        post_message("Unable to delete volume '#{@context[:source_volume_id]}' in source region: #{e.to_s}")
+      end
+      begin
+        delete_snapshot(@context[:snapshot_id])
+      rescue Exception => e
+        error << e
+        post_message("Unable to delete snapshot '#{@context[:snapshot_id]}' in source region: #{e.to_s}")
+      end
+      #XXX: delete Security Group according to its name
+      if @context[:source_security_group].eql?(Ec2Script::CS_SEC_GRP_NAME)
+        begin
+          delete_security_group(@context[:source_security_group])
+        rescue Exception => e
+          error << e
+          post_message("Unable to delete Security Group '#{@context[:source_security_group]}' in source region: #{e.to_s}")
+        end
+      end
+      #
       remote_region()
-      shut_down_instance(@context[:target_instance_id])
-      delete_volume(@context[:target_volume_id])
+      begin
+        shut_down_instance(@context[:target_instance_id])
+      rescue Exception => e
+        error << e
+        post_message("Unable to shutdown instance '#{@context[:target_instance_id]}' in target region: #{e.to_s}")
+      end
+      begin
+        delete_volume(@context[:target_volume_id])
+      rescue Exception => e
+        error << e
+        post_message("Unable to delete volume '#{@context[:target_volume_id]}' in target region: #{e.to_s}")
+      end
+      #XXX: delete Security Group according to its name
+      if @context[:target_security_group].eql?(Ec2Script::CS_SEC_GRP_NAME)
+        begin
+          delete_security_group(@context[:target_security_group])
+        rescue
+          error << e
+          post_message("Unable to delete Security Group '#{@context[:target_security_group]}' in target region: #{e.to_s}")
+        end
+      end
+
+      if error.size() > 0
+        raise Exception.new("Cleanup error(s)")
+      end
+
       Done.new(@context)
     end
   end

data/lib/scripts/ec2/copy_mswindows_ami.rb

@@ -69,17 +69,25 @@ class CopyMsWindowsAmi < Ec2Script
       raise Exception.new("Invalid target AMI ID specified: #{@input_params[:target_ami_id]}")
     end
     # AWS SecurityGroup, source and target regions
-    if @input_params[:source_security_groups] == nil
-      @input_params[:source_security_groups] = "default"
-    end
-    if !@local_ec2_helper.check_open_port(@input_params[:source_security_groups], 22)
-      raise Exception.new("Port 22 must be opened for security group '#{@input_params[:source_security_groups]}' to connect via SSH in source-region")
-    end
-    if @input_params[:target_security_groups] == nil
-      @input_params[:target_security_groups] = "default"
-    end
-    if !@remote_ec2_helper.check_open_port(@input_params[:target_security_groups], 22)
-      raise Exception.new("Port 22 must be opened for security group '#{@input_params[:target_security_groups]}' to connect via SSH in target-region")
+    if @input_params[:source_security_group] == nil
+      @input_params[:source_security_group] = "default"
+    end
+    if !@local_ec2_helper.check_open_port(@input_params[:source_security_group], 22)
+      #raise Exception.new("Port 22 must be opened for security group '#{@input_params[:source_security_group]}' to connect via SSH in source region")
+      post_message("'#{@input_params[:source_security_group]}' Security Group not opened port 22 for connect via SSH in source region")
+      @input_params[:source_security_group] = nil
+    else
+      post_message("'#{@input_params[:source_security_group]}' Security Group opened port 22 for connect via SSH in source region")
+    end
+    if @input_params[:target_security_group] == nil
+      @input_params[:target_security_group] = "default"
+    end
+    if !@remote_ec2_helper.check_open_port(@input_params[:target_security_group], 22)
+      #raise Exception.new("Port 22 must be opened for security group '#{@input_params[:target_security_group]}' to connect via SSH in target region")
+      post_message("'#{@input_params[:target_security_group]}' Security Group not opened port 22 for connect via SSH in target region")
+      @input_params[:target_security_group] = nil
+    else
+      post_message("'#{@input_params[:target_security_group]}' Security Group opened port 22 for connect via SSH in target region")
     end
     # Device to use for volume
     if @input_params[:root_device_name] == nil
@@ -104,9 +112,12 @@ class CopyMsWindowsAmi < Ec2Script
     if @input_params[:fs_type] == nil
       @input_params[:fs_type] = "ext3"
     end
-    if @input_params[:description] == nil || !check_string_alnum(@input_params[:description])
+    if @input_params[:description] == nil || !check_aws_desc(@input_params[:description])
       @input_params[:description] = "Created by CloudyScripts - #{self.class.name}"
     end
+    if @input_params[:name] == nil || !check_aws_name(@input_params[:name])
+      @input_params[:name] = "Created_by_CloudyScripts/#{self.class.name}_from_#{@input_params[:ami_id]}"
+    end
   end
 
   # Load the initial state for the script.
@@ -122,7 +133,6 @@ class CopyMsWindowsAmi < Ec2Script
 
     def self.load_state(context)
       InitialState.new(context)
-      
     end
 
     def local_region
@@ -145,7 +155,7 @@ class CopyMsWindowsAmi < Ec2Script
   #NB: if we do not own this AMI, we have no snapshot, so we must launch an instance
   class InitialState < CopyMsWindowsAmiState 
     def enter()
-      post_message("Retrieving AMI parammeters (snapshot ID, volume size, architecture)...")
+      post_message("Retrieving AMI parameters (snapshot ID, volume size, architecture)...")
       local_region()
       @context[:snapshot_id] = @local_ec2_helper.ami_blkdevmap_ebs_prop(@context[:ami_id], 'snapshotId')
       @context[:volume_size] = @local_ec2_helper.ami_blkdevmap_ebs_prop(@context[:ami_id], 'volumeSize')
@@ -167,7 +177,15 @@ class CopyMsWindowsAmi < Ec2Script
     def enter()
       post_message("Launching and stopping an instance of the AMI to create a snapshot")
       local_region()
-      result = launch_instance(@context[:ami_id], @context[:source_key_name], @context[:source_security_groups])
+      #XXX: create a CloudyScripts Security Group with TCP port 22 publicly opened
+      if @context[:source_security_group] == nil
+        @context[:source_security_group] = Ec2Script::CS_SEC_GRP_NAME
+        create_security_group_with_rules(@context[:source_security_group], Ec2Script::CS_SEC_GRP_DESC,
+          [{:ip_protocol => "tcp", :from_port => 22, :to_port => 22, :cidr_ip => "0.0.0.0/0"}])
+        post_message("'#{@context[:source_security_group]}' Security Group created with TCP port 22 publicly opened.")
+      end
+
+      result = launch_instance(@context[:ami_id], @context[:source_key_name], @context[:source_security_group])
       instance_id = result.first
       post_message("Instance launched with ID: #{instance_id}")
       post_message("Waiting 3 minutes before stopping instance '#{instance_id}' for creating a Snapshot of the rootDevice")
@@ -187,7 +205,15 @@ class CopyMsWindowsAmi < Ec2Script
     def enter()
       post_message("Launching an Helper instance in the source Region...")
       local_region()
-      result = launch_instance(@context[:source_ami_id], @context[:source_key_name], @context[:source_security_groups])
+      #XXX: create a CloudyScripts Security Group with TCP port 22 publicly opened
+      if @context[:source_security_group] == nil
+        @context[:source_security_group] = Ec2Script::CS_SEC_GRP_NAME
+        create_security_group_with_rules(@context[:source_security_group], Ec2Script::CS_SEC_GRP_DESC,
+          [{:ip_protocol => "tcp", :from_port => 22, :to_port => 22, :cidr_ip => "0.0.0.0/0"}])
+        post_message("'#{@context[:source_security_group]}' Security Group created with TCP port 22 publicly opened.")
+      end
+
+      result = launch_instance(@context[:source_ami_id], @context[:source_key_name], @context[:source_security_group])
       @context[:source_instance_id] = result.first
       @context[:source_dns_name] = result[1]
       @context[:source_availability_zone] = result[2]
@@ -273,7 +299,15 @@ class CopyMsWindowsAmi < Ec2Script
   class BackupedDataState < CopyMsWindowsAmiState 
     def enter()
       remote_region()
-      result = launch_instance(@context[:target_ami_id], @context[:target_key_name], @context[:target_security_groups])
+      #XXX: create a CloudyScripts Security Group with TCP port 22 publicly opened
+      if @context[:target_security_group] == nil
+        @context[:target_security_group] = Ec2Script::CS_SEC_GRP_NAME
+        create_security_group_with_rules(@context[:target_security_group], Ec2Script::CS_SEC_GRP_DESC,
+          [{:ip_protocol => "tcp", :from_port => 22, :to_port => 22, :cidr_ip => "0.0.0.0/0"}])
+        post_message("'#{@context[:target_security_group]}' Security Group created with TCP port 22 publicly opened.")
+      end
+
+      result = launch_instance(@context[:target_ami_id], @context[:target_key_name], @context[:target_security_group])
       @context[:target_instance_id] = result.first
       @context[:target_dns_name] = result[1]
       @context[:target_availability_zone] = result[2]
@@ -422,7 +456,7 @@ class CopyMsWindowsAmi < Ec2Script
       post_message("Launching Helper AMI '#{@context[:helper_ami_id]}' for attaching migrated volume...")
       remote_region()
       #XXX: launch instance in the right AZ
-      result = launch_instance(@context[:helper_ami_id], @context[:target_key_name], @context[:target_security_groups], 
+      result = launch_instance(@context[:helper_ami_id], @context[:target_key_name], @context[:target_security_group], 
                                nil, nil, @context[:target_availability_zone])
       @context[:helper_instance_id] = result.first
       @context[:helper_dns_name] = result[1]
@@ -481,6 +515,11 @@ class CopyMsWindowsAmi < Ec2Script
       shut_down_instance(@context[:source_instance_id])
       delete_volume(@context[:source_temp_volume_id])
       delete_volume(@context[:source_volume_id])
+      #XXX: delete Security Group according to its name
+      if @context[:source_security_group].eql?(Ec2Script::CS_SEC_GRP_NAME)
+        delete_security_group(@context[:source_security_group])
+      end
+
       #
       remote_region()
       connect(@context[:target_dns_name], @context[:target_ssh_username], nil, @context[:target_ssh_keydata])
@@ -491,6 +530,10 @@ class CopyMsWindowsAmi < Ec2Script
       shut_down_instance(@context[:target_instance_id])
       delete_volume(@context[:target_temp_volume_id])
       #delete_volume(@context[:target_volume_id])
+      #XXX: delete Security Group according to its name
+      if @context[:target_security_group].eql?(Ec2Script::CS_SEC_GRP_NAME)
+        delete_security_group(@context[:target_security_group])
+      end
  
       Done.new(@context)
     end