BnmAPI 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc66d3951b21035682a2b4b2f6ea0b4da1096d0d0e97b673c8882ed170181a3c
-  data.tar.gz: 6e1297d73b069c1b246010dd55569923f9331703663e4c64b1ff892f708486c7
+  metadata.gz: 4e807a48dfef08fab1c7ff16cbf87ef4fa4126b88db25fd89845bca0ce30b7cb
+  data.tar.gz: 6f1a037f5240ee78464a746173d1d34a3496ffcf18890ca3cd635835524eaa80
 SHA512:
-  metadata.gz: 5ac8cdb7b96ecf0f4579d99d2cf487cc0eba8bf54f0be6af3fc0b1e604fa47c2595b9c82756fecf14518669ad5081c1f41ed33a715a5efa7ed899ddd2ba0ab91
-  data.tar.gz: e99bfa3283a5c872ef932bcfd1084a16299410905f51bc54304e159d04066b0a92e66de288a24ded7e5237f53170482542eb6fb0a2cdf42edb3cb9b54acd5c5e
+  metadata.gz: bc11fd9bc51ca071f3e1981825d8b05fb64a6da0dd8be77a35574670ba913dd113a02211445ef218b479b7566197342770c799b993f0a1ffdfc9ab25cbedef36
+  data.tar.gz: 9a484fbdcac03ee856ed1e8b6961e835217a02bfeaaadbfd9e3087182108791070d2dd8c3ca573d6535d52679d8df673dcb9f797814fd062d78ce6497fa4bc12

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    BnmAPI (0.0.1)
+    BnmAPI (0.1.0)
 
 GEM
   remote: https://rubygems.org/

data/bnmapi.gemspec

@@ -14,26 +14,6 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/jibone/bnmapi"
   spec.license       = "MIT"
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
-  #if spec.respond_to?(:metadata)
-  #  spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"
-
-  #  spec.metadata["homepage_uri"] = spec.homepage
-  #  spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
-  #  spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
-  #else
-  #  raise "RubyGems 2.0 or newer is required to protect against " \
-  #    "public gem pushes."
-  #end
-
-  ## Specify which files should be added to the gem when it is released.
-  ## The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  #spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
-  #  `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  #end
-  #spec.bindir        = "exe"
-  #spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
@@ -49,5 +29,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency 'webmock'
   spec.add_development_dependency 'vcr'
-
 end

data/lib/bnmapi/base_rate.rb

@@ -28,7 +28,12 @@ module BnmAPI
     def self.by_bank_code(bank_code)
       http = BnmAPI::HTTP::Client.new(endpoint: ENDPOINT + '/' + bank_code)
 
-      res = JSON.parse(http.request.read_body)
+      response = http.request
+      if response.code == '404'
+        raise BnmAPI::Error::InvalidBankCode.new(bank_code: bank_code)
+      end
+
+      res = JSON.parse(response.read_body)
 
       BnmAPI::Data::BankBaseRate.new(
           res['data']['bank_code'],

data/lib/bnmapi/error/invalid_bank_code.rb

@@ -0,0 +1,10 @@
+module BnmAPI::Error
+  class InvalidBankCode < StandardError
+    attr_reader :bank_code
+
+    def initialize(msg: 'Invalid bank code', bank_code:)
+      @bank_code = bank_code
+      super(msg + ': ' + bank_code)
+    end
+  end
+end

data/lib/bnmapi/version.rb

@@ -1,3 +1,3 @@
 module BnmAPI
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/lib/bnmapi.rb

@@ -1,10 +1,10 @@
 require 'bnmapi/version'
 require 'bnmapi/http/client'
 require 'bnmapi/data/bank_base_rate'
+require 'bnmapi/error/invalid_bank_code'
 require 'bnmapi/welcome'
 require 'bnmapi/base_rate'
 
 module BnmAPI
-  class Error < StandardError; end
   # Your code goes here...
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: BnmAPI
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - J Shamsul Bahri (jibone))
@@ -104,6 +104,7 @@ files:
 - lib/bnmapi.rb
 - lib/bnmapi/base_rate.rb
 - lib/bnmapi/data/bank_base_rate.rb
+- lib/bnmapi/error/invalid_bank_code.rb
 - lib/bnmapi/http/client.rb
 - lib/bnmapi/version.rb
 - lib/bnmapi/welcome.rb