Avatax_TaxService 1.0.12 → 1.0.13

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2JhMDM0YTBiNmUwN2NhZGYzOTg4ZWFmOGNlYTJmODgyYWMwY2ExNw==
+    ZGJiODRjYzA0ZmIwOTYwMDE3NDYyNzE3NGY3OTViMzA5Nzg2MzEzOQ==
   data.tar.gz: !binary |-
-    MWE5MmQ5MDc4ODRjNzk4NzUyMzQyNzhhYzViOGJjZTZmNzdjMzc2OA==
+    MTZkM2MzODkzYmY2OTc3YjNiZWM3OGQzMzJmMTAyNjE3Y2YwYjQ4Nw==
 SHA512:
   metadata.gz: !binary |-
-    OGVhODZlZjQ3OTFkMWY2NzE5ZmI3OGQwMGJiYWE3M2NiMGYxOTllZjJhYjVj
-    NzdiYzU1NDUyZjkxNWRjZjMyYzFmYmVlNmM0NmFlZTgwMjE3YTdhMjMyNmI5
-    MjU3ZDBmN2U3NjJkOGQyOWYzZmFiYmIzNTIyMTdkNzA4OWUyZGU=
+    NDMzNDc4YTE5OGZjNmNmYTY2NTI5NTk4ZTFhYWYzZTNiMGM2ODkwN2E1OTM1
+    ZDQxZDJlZTY4MDVhYTM4Y2U5OTM1NjBkYzU0NzMyZDMzOGU5NmRhNWZlZjQy
+    ZGVlMzkyZjM2ODNmMmE2ZTBmMmUwOGM1NGIzYjcyZTlkMDI5YzY=
   data.tar.gz: !binary |-
-    OTBkZWVlNzU3ZmUwZDBjNjA4NDU5ZTQ0NmYyZWNmZmE5ZWY0NDAzYTE5YjA4
-    NmZkZDdiNDIxOWVlMjQwYTI0Mzg4OWE2OGRlOTdlNDc0YmJhNjA4ZTM5MThm
-    YzgyYTRhMGM2NjExZTExOTJhODRhYjJiZDhmYWQ5ZTAyNjIwNWU=
+    NWJmMDcyZmRkN2FjNWIzMjI3MjVhNGJlYWE1NGU2NWQ2NmNjMTQ1OTdmMTUy
+    NDBmYzRjNjk5Y2VkYjVhZjVkY2E5MTkyMWIxNjk3ODM5NWRiZTU0OWIxOTMw
+    YTNhMzE5YTVhOTk0M2I1YWY5M2U2NzAwMjc5MTlhYWYwNGUzMTU=

data/Avatax_TaxService.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "Avatax_TaxService"
-  s.version = "1.0.12"
+  s.version = "1.0.13"
   s.date = "2012-10-28"
   s.author = "Graham S Wilson"
   s.email = "support@Avalara.com"

data/lib/avatax_taxservice.rb

@@ -156,7 +156,7 @@ module AvaTax
         end
       
       #Strip off outer layer of the hash - not needed
-      @response = @response[:ping_response][:ping_result]
+      @response = messages_to_array(@response[:ping_response][:ping_result])
           
       return @response
     
@@ -236,7 +236,7 @@ module AvaTax
         end
 
       #Strip off outer layer of the hash - not needed
-      @response = @response[:get_tax_response][:get_tax_result]
+      @response = messages_to_array(@response[:get_tax_response][:get_tax_result])
 
       #Return data to calling program
       return @response
@@ -317,7 +317,7 @@ module AvaTax
         end
 
       #Strip off outer layer of the hash - not needed
-      return @response[:adjust_tax_response][:adjust_tax_result]
+      return messages_to_array(@response[:adjust_tax_response][:adjust_tax_result])
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -369,7 +369,7 @@ module AvaTax
 
       #Strip off outer layer of the hash - not needed
       #Return data to calling program
-      return @response[:post_tax_response][:post_tax_result]
+      return messages_to_array(@response[:post_tax_response][:post_tax_result])
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -419,7 +419,7 @@ module AvaTax
 
       #Strip off outer layer of the hash - not needed
       #Return data to calling program
-      return @response[:commit_tax_response][:commit_tax_result]
+      return messages_to_array(@response[:commit_tax_response][:commit_tax_result])
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -467,7 +467,7 @@ module AvaTax
         end
 
       #Strip off outer layer of the hash - not needed
-      return @response[:cancel_tax_response][:cancel_tax_result]
+      return messages_to_array(@response[:cancel_tax_response][:cancel_tax_result])
 
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -515,7 +515,7 @@ module AvaTax
         end
         
       #Strip off outer layer of the hash - not needed
-      return @response[:get_tax_history_response][:get_tax_history_result]
+      return messages_to_array(@response[:get_tax_history_response][:get_tax_history_result])
 
       
       #Capture unexpected errors
@@ -571,7 +571,7 @@ module AvaTax
         end
 
       #Strip off outer layer of the hash - not needed
-      return @response[:reconcile_tax_history_response][:reconcile_tax_history_result]
+      return messages_to_array(@response[:reconcile_tax_history_response][:reconcile_tax_history_result])
 
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -601,7 +601,7 @@ module AvaTax
         @response = @client.call(:is_authorized, xml: @soap).to_hash
 
       #Strip off outer layer of the hash - not needed
-      return @response[:is_authorized_response][:is_authorized_result]
+      return messages_to_array(@response[:is_authorized_response][:is_authorized_result])
       
       #Capture unexpected errors
       rescue Savon::Error => error
@@ -621,8 +621,29 @@ module AvaTax
       @response[:result_code] = 'Error'
       @response[:summary] = @response[:fault][:faultcode]
       @response[:details] = @response[:fault][:faultstring]   
-      return @response
+      return messages_to_array(@response)
+    end
+    ############################################################################################################
+    #standardizes error message format to an array of messages - nokogiri will collapse a single element array into the response hash.
+    ############################################################################################################
+    def messages_to_array(response)
+      if not response[:messages].nil? 
+        return response
+      end
+      # add the messages array to the response - if we got here, there was only one error.
+      response[:messages] = [{
+        :summary => response[:summary],
+        :details => response[:details],
+        :helplink => response[:helplink],
+        :refersto => response[:refersto],
+        :severity => response[:severity],
+        :source => response[:source]
+        }]
+      #remove all the error information from the hash  
+      response[:messages][0].each do |k,v|
+        response.delete(k)
+      end  
+      return response
     end
-  
   end
 end  

data/samples/GetTaxHistory.rb

@@ -15,7 +15,7 @@ svc = AvaTax::TaxService.new(:username => credentials['username'],
     :doctype=>"SalesInvoice", #Required
     :docid=> "",              #Optional
     :detaillevel=>"Tax",      #Optional
-    :debug => false           #Optional
+    :debug => true           #Optional
     }
   #Call the service
 result = svc.gettaxhistory(request)

data/samples/credentials.yml

@@ -2,4 +2,4 @@ username: username
 password: password
 clientname: AvaTaxCalcSOAP Ruby Sample
 production: false
-companycode: APITrialCompany
+companycode: 1

data/spec/adjusttax_spec.rb

@@ -167,7 +167,9 @@ describe "AdjustTax" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.adjusttax(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/canceltax_spec.rb

@@ -74,7 +74,9 @@ describe "CancelTax" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.canceltax(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/committax_spec.rb

@@ -85,7 +85,9 @@ describe "CommitTax" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.committax(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/gettax_spec.rb

@@ -149,7 +149,9 @@ describe "GetTax" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.gettax(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/gettaxhistory_spec.rb

@@ -74,7 +74,9 @@ describe "GetTaxHistory" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.gettaxhistory(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/isauthorized_spec.rb

@@ -46,7 +46,9 @@ describe "IsAuthorized" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.isauthorized
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/ping_spec.rb

@@ -46,7 +46,9 @@ describe "Ping" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.ping
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/posttax_spec.rb

@@ -84,7 +84,9 @@ describe "PostTax" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.posttax(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

data/spec/reconciletaxhistory_spec.rb

@@ -78,7 +78,9 @@ describe "ReconcileTaxHistory" do
       @creds[:password] = nil
       @service = AvaTax::TaxService.new(@creds)
       @result = @service.reconciletaxhistory(@request_required)
-      @result[:result_code].should eql "Error" and @result[:details].should eql "The user or account could not be authenticated."
+      @result[:result_code].should eql "Error" and       
+      @result[:messages].kind_of?(Array).should eql true and
+      @result[:messages][0].should include(:details => "The user or account could not be authenticated.")
     end
     it "successful results" do
       @service = AvaTax::TaxService.new(@creds)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: Avatax_TaxService
 version: !ruby/object:Gem::Version
-  version: 1.0.12
+  version: 1.0.13
 platform: ruby
 authors:
 - Graham S Wilson