ActiveMerchant-FatZebra 1.0.0 → 1.0.1

data/ActiveMerchant-FatZebra.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "ActiveMerchant-FatZebra"
-  s.version     = "1.0.0"
+  s.version     = "1.0.1"
   s.authors     = ["Matthew Savage"]
   s.email       = ["matthew.savage@fatzebra.com.au"]
   s.homepage    = "https://www.fatzebra.com.au"

data/lib/active_merchant/billing/gateways/fat_zebra.rb

@@ -116,8 +116,7 @@ module ActiveMerchant #:nodoc:
           message,
           response,
           :test => response.has_key?("test") ? response["test"] : false,
-          :authorization => response["response"]["authorization"],
-          :id => response["response"]["id"])
+          :authorization => response["response"]["id"] || response["response"]["token"])
       end
 
       # Parse the returned JSON, if parse errors are raised then return a detailed error.
@@ -144,7 +143,7 @@ module ActiveMerchant #:nodoc:
       # Builds the auth and U-A headers for the request
       def headers
         {
-          "Authorization" => "Basic " + Base64.encode64(@username.to_s + ":" + @token.to_s).strip,
+          "Authorization" => "Basic " + Base64.strict_encode64(@username.to_s + ":" + @token.to_s).strip,
           "User-Agent" => "Fat Zebra v1.0/ActiveMerchant #{ActiveMerchant::VERSION}"
         }
       end 

data/test/remote/gateways/remote_fat_zebra_test.rb

@@ -38,7 +38,7 @@ class RemoteFatZebraTest < Test::Unit::TestCase
   def test_refund
     purchase = @gateway.purchase(@amount, @credit_card, @options)
     
-    assert response = @gateway.refund(@amount, purchase.params["response"]["id"], rand(1000000).to_s)
+    assert response = @gateway.refund(@amount, purchase.authorization, rand(1000000).to_s)
     assert_success response
     assert_match /Approved/, response.message
   end

data/test/unit/gateways/fat_zebra_test.rb

@@ -23,8 +23,7 @@ class FatZebraTest < Test::Unit::TestCase
     assert response = @gateway.purchase(@amount, @credit_card, @options)
     assert_success response
 
-    # Replace with authorization number from the successful response
-    assert_equal '55355', response.authorization
+    assert_equal '001-P-12345AA', response.authorization
     assert response.test?
   end
 
@@ -75,6 +74,23 @@ class FatZebraTest < Test::Unit::TestCase
     assert_failure response
   end
 
+  def test_successful_refund
+    @gateway.expects(:ssl_request).returns(successful_refund_response)
+
+    assert response = @gateway.refund(100, "TEST", "Test refund")
+    assert_success response
+    assert_equal '003-R-7MNIUMY6', response.authorization
+    assert response.test?
+  end
+
+  def test_unsuccessful_refund
+    @gateway.expects(:ssl_request).returns(unsuccessful_refund_response)
+
+    assert response = @gateway.refund(100, "TEST", "Test refund")
+    assert_failure response
+    assert response.test?
+  end
+
   private
 
   # Place raw successful response from gateway here
@@ -117,6 +133,52 @@ class FatZebraTest < Test::Unit::TestCase
     }.to_json
   end
 
+  def successful_refund_response
+    {
+      :successful => true,
+      :response => {
+        :authorization => "1339973263",
+        :id => "003-R-7MNIUMY6",
+        :amount => -10,
+        :refunded => "Approved",
+        :message => "08 Approved",
+        :card_holder => "Harry Smith",
+        :card_number => "XXXXXXXXXXXX4444",
+        :card_expiry => "2013-05-31",
+        :card_type => "MasterCard",
+        :transaction_id => "003-R-7MNIUMY6",
+        :successful => true
+      },
+      :errors => [
+
+      ],
+      :test => true
+    }.to_json
+  end
+
+  def unsuccessful_refund_response
+    {
+      :successful => false,
+      :response => {
+        :authorization => nil,
+        :id => nil,
+        :amount => nil,
+        :refunded => nil,
+        :message => nil,
+        :card_holder => "Matthew Savage",
+        :card_number => "XXXXXXXXXXXX4444",
+        :card_expiry => "2013-05-31",
+        :card_type => "MasterCard",
+        :transaction_id => nil,
+        :successful => false
+      },
+      :errors => [
+        "Reference can't be blank"
+      ],
+      :test => true
+    }.to_json
+  end
+
   def successful_tokenize_response
     {
       :successful => true,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ActiveMerchant-FatZebra
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-16 00:00:00.000000000 Z
+date: 2012-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant
-  requirement: &70121469611100 !ruby/object:Gem::Requirement
+  requirement: &70156374511060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70121469611100
+  version_requirements: *70156374511060
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70121469610340 !ruby/object:Gem::Requirement
+  requirement: &70156374510460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70121469610340
+  version_requirements: *70156374510460
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70121469608900 !ruby/object:Gem::Requirement
+  requirement: &70156374509640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.11.3
   type: :development
   prerelease: false
-  version_requirements: *70121469608900
+  version_requirements: *70156374509640
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70121469645180 !ruby/object:Gem::Requirement
+  requirement: &70156374508320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: 2.3.11
   type: :development
   prerelease: false
-  version_requirements: *70121469645180
+  version_requirements: *70156374508320
 description: Fat Zebra support for Active Merchant - temporary gem until support is
   combined into active_merchant core.
 email:
@@ -89,7 +89,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3400427441090863407
+      hash: 4098293208701406375
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -98,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3400427441090863407
+      hash: 4098293208701406375
 requirements: []
 rubyforge_project: ActiveMerchant-FatZebra
 rubygems_version: 1.8.10